feat/solana tbtc canonical #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
had a problem deploying
to
Cloudflare-Testnet
GitHub Actions
Failure
sebastianscatularo
had a problem deploying
to
Cloudflare-Preview
GitHub Actions
Failure
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
had a problem deploying
to
Cloudflare-Testnet
GitHub Actions
Error
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
had a problem deploying
to
Cloudflare-Preview
GitHub Actions
Error
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
had a problem deploying
to
Cloudflare-Testnet
GitHub Actions
Failure
sebastianscatularo
had a problem deploying
to
Cloudflare-Preview
GitHub Actions
Failure
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
requested review from
valentinoConti,
M-Picco,
gabzim,
raop155,
yuli-ferna and
giulianoconti
gabzim
reviewed
Aug 13, 2023
| }) | ||
| ); | ||
| return; | ||
| } else { |
There was a problem hiding this comment.
this else should be redundant if you're returning above, right?
There was a problem hiding this comment.
yes, but due to the nature of this code, we want to interrupt the execution here, to avoid checking the other ifs like the
if (isTerraChain(sourceChain) && sourceAsset) {
gabzim
reviewed
Aug 13, 2023
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
valentinoConti
approved these changes
Aug 14, 2023
sebastianscatularo
added a commit
that referenced
this pull request
Aug 18, 2023
* create associated account works * fix base58 address convertion for Solana gateway program * pull accounts from custodia account * implement send< btct * update tokenBridgeWrappedAsset account derivation to send tbtc to solana * setup sender arguments * [skip ci] - run prettier * remove unecesary console.log * remove unecesary console.log * fix parameters to send back to L1 * create ata for the redeem process * handle case for sending from non L1 to a non L1 evm chain * cosmetic changes * initialize associate token account if not exist * call the gateway if the asset is tBtc v2 * [skip ci] - run prettier * add mainnet address * [skip ci] - bump version * code review observation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.