Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

175 Bug fix 'Cannonical token' message is not displayed on “Are you sure?” pop-up #304

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

yuli-ferna
Copy link
Collaborator

The canonical message must be shown when:

  • Ethereum is the target and the asset is tBTC, the canonical message should be displayed.
  • Any combination of source - target with eth, polygon, arbitrum, optimism, base, and solana, with tBTC.

I deleted the isWormholeWrapped condition because It's not necessary.

Result:

image
image
image
image
image

@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 18:57 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 18:57 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 18:57 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 18:57 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 19:07 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 19:10 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 19:54 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 19:54 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 19:54 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 19:54 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 15, 2023 20:04 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 15, 2023 20:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 16, 2023 13:58 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 16, 2023 13:58 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 16, 2023 13:58 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 16, 2023 13:58 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet August 16, 2023 14:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview August 16, 2023 14:09 — with GitHub Actions Inactive
@sebastianscatularo
Copy link
Collaborator

🚀 LGTM

@yuli-ferna yuli-ferna merged commit ecef965 into main Aug 16, 2023
10 checks passed
@yuli-ferna yuli-ferna deleted the bugfix/175-canonical-token branch August 16, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants