Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac UT check #5196

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Mac UT check #5196

wants to merge 2 commits into from

Conversation

oleks-rip
Copy link
Collaborator

@oleks-rip oleks-rip commented Nov 18, 2024

High Level Overview of Change

MACOS unit tests fix

Context of Change

Add retries to Env RPC requests to fix Macos disconnects during CI testing.
RPC server use ip ports assigned by operating system automatically (instead of hard-coded) when unit tests run.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

  • No API impact

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (0ec17b6) to head (6799369).

Files with missing lines Patch % Lines
src/xrpld/core/detail/Config.cpp 89.5% 2 Missing ⚠️
src/xrpld/rpc/detail/ServerHandler.cpp 85.7% 2 Missing ⚠️
src/xrpld/app/main/Application.cpp 94.1% 1 Missing ⚠️
src/xrpld/app/main/GRPCServer.cpp 93.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5196     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          782     782             
  Lines        66622   66677     +55     
  Branches      8136    8156     +20     
=========================================
+ Hits         51902   51930     +28     
- Misses       14720   14747     +27     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.2% <ø> (ø)
include/xrpl/server/detail/ServerImpl.h 92.5% <100.0%> (+0.8%) ⬆️
src/libxrpl/basics/BasicConfig.cpp 89.6% <100.0%> (ø)
src/libxrpl/server/Port.cpp 76.8% <100.0%> (+0.2%) ⬆️
src/xrpld/app/main/GRPCServer.h 100.0% <ø> (ø)
src/xrpld/overlay/detail/OverlayImpl.cpp 34.7% <100.0%> (ø)
src/xrpld/rpc/ServerHandler.h 100.0% <100.0%> (ø)
src/xrpld/app/main/Application.cpp 69.3% <94.1%> (+0.4%) ⬆️
src/xrpld/app/main/GRPCServer.cpp 44.4% <93.3%> (+2.0%) ⬆️
src/xrpld/core/detail/Config.cpp 74.2% <89.5%> (+0.7%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:

@oleks-rip oleks-rip marked this pull request as ready for review November 22, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant