Use types over records

XYOracleNetwork · Jun 27, 2023 · 21ec151 · 21ec151
1 parent 87e4d0b
commit 21ec151
Showing 1 changed file with 16 additions and 25 deletions.
diff --git a/packages/plugins/packages/payload/packages/crypto/packages/nft/src/Diviner/Payload.ts b/packages/plugins/packages/payload/packages/crypto/packages/nft/src/Diviner/Payload.ts
@@ -9,31 +9,22 @@ export type ScaledScore = [total: number, possible: number]
 export const SKIP: ScaledScore = [0, 0]
 export type Score = ScaledScore | PassFailScore
 
-const attributesScoringCriteria = {
-  Attributes: true,
-}
-
-const metadataScoringCriteria = {
-  'Animation URL': true,
-  'Background Color': true,
-  Description: true,
-  'External Url': true,
-  Image: true,
-  'Image Data': true,
-  Name: true,
-  'YouTube URL': true,
-  ...attributesScoringCriteria,
-}
-
-export const scoringCriteria = {
-  'Contract Address': true,
-  Supply: true,
-  'Token Id': true,
-  Type: true,
-  ...metadataScoringCriteria,
-}
-
-type ScoringCriteriaKey = keyof typeof scoringCriteria & PropertyKey
+export type AttributesScoringCriteria = 'Attributes'
+
+export type MetadataScoringCriteria =
+  | 'Animation URL'
+  | 'Background Color'
+  | 'Description'
+  | 'External Url'
+  | 'Image'
+  | 'Image Data'
+  | 'Name'
+  | 'YouTube URL'
+  | AttributesScoringCriteria
+
+export type ScoringCriteria = 'Contract Address' | 'Supply' | 'Token Id' | 'Type' | MetadataScoringCriteria
+
+export type ScoringCriteriaKey = ScoringCriteria & PropertyKey
 
 export type NftAnalysis = {
   [key in ScoringCriteriaKey]: Score