Better test cases for edge cases

XYOracleNetwork · Sep 24, 2024 · cf6b84a · cf6b84a
1 parent 7538b99
commit cf6b84a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...kages/boundwitness/packages/validator/src/lib/addresses/spec/addressesContainsAll.spec.ts b/...kages/boundwitness/packages/validator/src/lib/addresses/spec/addressesContainsAll.spec.ts
@@ -26,12 +26,16 @@ describe('addressesContainsAll', () => {
       ['with single wallet', () => oneWallet],
       ['with multiple wallets', () => twoWallets],
     ]
+    it('with no signers and empty addresses supplied', async () => {
+      const bw = await buildBoundWitness([])
+      expect(addressesContainsAll(bw, [])).toBeTrue()
+    })
     describe.each(cases)('%s', (_, wallets) => {
       let addresses: Address[]
       beforeAll(() => {
         addresses = wallets().map(x => x.address)
       })
-      it('with no signers and empty addresses supplied', async () => {
+      it('with  all wallets as signers and empty addresses supplied', async () => {
         const bw = await buildBoundWitness(wallets())
         expect(addressesContainsAll(bw, [])).toBeTrue()
       })

diff --git a/...kages/boundwitness/packages/validator/src/lib/addresses/spec/addressesContainsAny.spec.ts b/...kages/boundwitness/packages/validator/src/lib/addresses/spec/addressesContainsAny.spec.ts
@@ -23,15 +23,15 @@ describe('addressesContainsAny', () => {
       ['with single wallet', () => oneWallet],
       ['with multiple wallets', () => twoWallets],
     ]
+    it('with no signers and empty addresses supplied', async () => {
+      const bw = await buildBoundWitness([])
+      expect(addressesContainsAny(bw, [])).toBeFalse() // No signers and no addresses should return false
+    })
     describe.each(cases)('%s', (_, wallets) => {
       let addresses: Address[]
       beforeAll(() => {
         addresses = wallets().map(x => x.address)
       })
-      it('with no signers and empty addresses supplied', async () => {
-        const bw = await buildBoundWitness([])
-        expect(addressesContainsAny(bw, [])).toBeFalse() // No signers and no addresses should return false
-      })
       it('with all wallets as signers and all wallet addresses supplied', async () => {
         const bw = await buildBoundWitness(wallets())
         expect(addressesContainsAny(bw, addresses)).toBeTrue() // Should be true if wallets exist