-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cft #484
Merged
Merged
New cft #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalan-motamedi
added
the
no changelog
Pull request does not require a CHANGELOG entry
label
Sep 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #484 +/- ##
===========================================
+ Coverage 89.56% 89.60% +0.03%
===========================================
Files 101 102 +1
Lines 7392 7415 +23
===========================================
+ Hits 6621 6644 +23
Misses 771 771
Continue to review full report in Codecov by Sentry.
|
apchytr
reviewed
Sep 5, 2024
apchytr
reviewed
Sep 5, 2024
apchytr
reviewed
Sep 5, 2024
apchytr
reviewed
Sep 5, 2024
apchytr
reviewed
Sep 5, 2024
apchytr
reviewed
Sep 6, 2024
apchytr
approved these changes
Sep 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Introducing the CFT (Complex Fourier Transform) gate. The previous CFT branch had some issues. Here we address them. However, the class
CFT
remains unchanged.Description of the Change:
Updating tests.
Benefits:
CFT allows computing Wigner functions of arbitrary objects.
Possible Drawbacks:
Need to keep track of hbar by hand in Wigner function evaluations.
Related GitHub Issues:
None.