Symplectic override on Ggate

mrmustard/lab_dev/transformations/ggate.py

@@ -55,10 +55,14 @@ def __init__(
  symplectic_trainable: bool = False,
  ):
  super().__init__(modes_out=modes, modes_in=modes, name="Ggate")
- S = make_parameter(symplectic_trainable, symplectic, "symplectic", (None, None))
- self.parameter_set.add_parameter(S)
-
+ self._add_parameter(
+  make_parameter(symplectic_trainable, symplectic, "symplectic", (None, None))
+ )
  self._representation = Bargmann.from_function(
  fn=lambda s: Unitary.from_symplectic(modes, s).bargmann_triple(),
  s=self.parameter_set.symplectic,
  )
+
+ @property
+ def symplectic(self):
+ return self.parameter_set.symplectic.value

tests/test_lab_dev/test_transformations/test_ggate.py

@@ -30,6 +30,7 @@ def test_init(self):
  Eye = Ggate(modes=[0], symplectic=math.eye(2))
  assert isinstance(Eye, Ggate)
  assert Eye.name == "Ggate"
+ assert math.allclose(Eye.symplectic, math.eye(2))
 
  def test_ggate_is_unitary_1mode(self):
  """Test that the Ggate applied to its dual is the identity."""