reduced state fix #395
Merged
reduced state fix #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1912 1914 +2
=========================================
+ Hits 1912 1914 +2
Continue to review full report in Codecov by Sentry.
|
nquesada
reviewed
Jul 9, 2024
| @@ -171,6 +171,9 @@ def reduced_state(mu, cov, modes): | |||
| """ | |||
| N = len(mu) // 2 | |||
|
|
|||
| if type(modes) == np.ndarray: | |||
There was a problem hiding this comment.
You probably need to add a test to trigger this line.
There was a problem hiding this comment.
Thank you. I added the test!
nquesada
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There was a code that compare the value in numpy.ndarray and list in
reduced_state(numpy.ndarray == list). This comparison was allowed in the previous version of numpy but prohibited in the latest one. Therefore, an error is raised.Description of the Change:
Codes to convert the type from numpy.ndarray to list was added.
Benefits:
The error is fixed.
Possible Drawbacks:
This change may break other parts because codes to restore the type after the comparison have not been implemented.
Related GitHub Issues: