-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inclusion of context menu in all documents #460
base: master
Are you sure you want to change the base?
Conversation
@@ -235,9 +222,6 @@ | |||
<IDSymbol name="GroupIDXamlStylerContextCrossProjectMultiSolutionFolderGroup" value="0x105a" /> | |||
<IDSymbol name="GroupIDXamlStylerContextCrossProjectMultiProjectFolderGroup" value="0x105b" /> | |||
|
|||
<!-- This is the command set for the document tab context menu --> | |||
<IDSymbol name="GroupIDXamlStylerContextDocumentTabGroup" value="0x1070" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed this comment previously.
The current (prior to this PR) version adds the "Format XAML" option to the context menu on the tab of any document window. Am I right to assume this should be filtered to just xaml files also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is ideally filtered to xaml (and axaml) files.
@@ -35,12 +35,6 @@ | |||
<Group guid="GuidXamlStylerMenuSet" id="GroupIDXamlStylerMenu" priority="0x0001"> | |||
<Parent guid="GuidVisualStudioXAMLWindowContextMenu" id="IDVisualStudioXAMLWindowContextMenu"/> | |||
</Group> | |||
<Group guid="GuidXamlStylerMenuSet" id="GroupIDXamlStylerMenu" priority="0x0001"> | |||
<Parent guid="GuidVisualStudioXamarWindowContextMenu" id="IDVisualStudioXamarinWindowContextMenu"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicoVermeir do you recall why we added these Xamarin-specific entries? Are they still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they were there for AXAML support :/
Here's an update on my current investigation into resolving the issues blocking this. Everything here comes with a big AFAIK disclaimer. There is an existing context menu for when editing XAML documents. Adding to this is easy and was part of the original PR. The context menu for the document tab is separate and is the same for all document types. I can add to this and filter it so it only shows based on the "Content Type" of the active document. I can do this for XAML files.
AXAML documents use the standard code editor, but there is no specific context menu to add to that only shows for AXAML documents. I can add the "Format XAML" option to this menu but haven't been able to get it to only show based on the file extension. AXAML documents have a content type of "xml". I can't get filtering on this content type to work correctly. 😞 I will keep investigating and trying to get this all working as desired.... |
Description:
Fixes #132 (issue)
This removes unneeded and incorrect VSCT entries for the "Format XAML" context menu option.
0x040D
of the "VS Main Menu") - I can't find a definitionI assume the "Xamarin" entry was added for a special case (in an earlier version of VS) that no longer applies.
Checklist: