Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rider 2024.3 #515

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

johanneswolfgruber
Copy link

Description:

Fixes #514

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my changes by running the extension in VS2017
  • I have tested my changes by running the extension in VS2019
  • I have tested my changes by running the extension in VS2022
  • If changes to the documentation are needed, I have noted this in the description above

@JohnTraDolta
Copy link

After some investigation i can see that in RiderXamlStylerHost.cs the SolutionComponentAttribute is obsolete and it should be used with the Instantiation enum.

Not sure what the right option is here but Instantiation.DemandAnyThreadSafe should be the best option.
So maybe

...
   [SolutionComponent(Instantiation.DemandAnyThreadSafe)]
    public class RiderXamlStylerHost
    {
...

@johanneswolfgruber
Copy link
Author

Thanks, I also just saw that and will try if that fixes the build issue.

@johanneswolfgruber
Copy link
Author

I think I also need to update the JDK version

The Java configuration specifies sourceCompatibility='17' but IntelliJ Platform '2024.3' requires sourceCompatibility='21'

@johanneswolfgruber
Copy link
Author

Sorry, there is still an issue:

import com.jetbrains.rider.ideaInterop.fileTypes.xaml.XamlLanguage cannot be resolved.

I could not find anything about it for now, will keep looking, but if someone knows what to do, help is appreciated.

@JohnTraDolta
Copy link

I will try and see if i can find anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rider 2024.3 is out and XamlStyler rider plugin needs an update
2 participants