Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIB-4282] OpenAPI spec has paging info for Associations/objectid #572

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

rob-wigmore
Copy link
Contributor

OpenAPI spec has paging info for Associations/objectid

Description

Paging information has been added to the OpenAPI spec on the associations/{objectid} endpoint

Release Notes

The endpoint was updated and the Open API spec needs to be updated to reflect the new functionality
https://xero.atlassian.net/browse/APIB-4282

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Co-authored-by: Fiachra Shanahan <fiachra.shanahan@xero.com>
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

PETOSS-346

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thanks for raising an issue, a ticket has been created to track your request

@rdemarco-xero
Copy link
Collaborator

@rob-wigmore - In the developer documentation PR there is an example of the sort query param alongside a direction query param like this: Associations/{ObjectId}?sort=CreatedDateUtc&direction=DESC

Should direction be added as an additional param in the spec here?

…ations/objectid

Co-authored-by: Fiachra Shanahan <fiachra.shanahan@xero.com>
@rob-wigmore
Copy link
Contributor Author

@rob-wigmore - In the developer documentation PR there is an example of the sort query param alongside a direction query param like this: Associations/{ObjectId}?sort=CreatedDateUtc&direction=DESC

Should direction be added as an additional param in the spec here?

Thanks for that, we have included direction in the latest commit.

@rdemarco-xero rdemarco-xero merged commit 0c6e57a into XeroAPI:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants