Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STA-948] Add disallowed expenses #583

Merged
merged 1 commit into from
May 2, 2024

Conversation

MichaelTranXero
Copy link
Contributor

@MichaelTranXero MichaelTranXero commented Feb 14, 2024

Description

Add tax types and report tax types for Disallowed Expenses tax rates in the Singapore region.

Release Notes

New tax rates are being introduced for compliance reasons

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-392

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@0GH4J
Copy link
Contributor

0GH4J commented Feb 22, 2024

@manishT72 - this one is good to go

Copy link
Contributor

@GlenXero GlenXero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelTranXero MichaelTranXero marked this pull request as draft February 25, 2024 23:54
@manishT72
Copy link
Contributor

@MichaelTranXero I see you have moved the PR back to Draft. Is it not ready for release?

@MichaelTranXero MichaelTranXero marked this pull request as ready for review April 16, 2024 04:47
@MichaelTranXero
Copy link
Contributor Author

@MichaelTranXero I see you have moved the PR back to Draft. Is it not ready for release?

I've just marked it ready for release

@manishT72 manishT72 merged commit 5a41eb2 into XeroAPI:master May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants