Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIB-5670] Add threshold Warnings to responses #609

Merged

Conversation

kayoung-kim-xero
Copy link
Contributor

Add threshold Warnings object to responses

Description

Currently Warnings object is returned from the public API but not SDKs. Adding this object into the SDK response to align with the public doc and public API.

Screenshots (if appropriate):

image

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-475

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@kayoung-kim-xero
Copy link
Contributor Author

@manishT72 Hi Manish, I don't think I've got the permission to add you as reviewer, could you please review this PR? Thanks!

Copy link
Contributor

@sangeet-joy-tw sangeet-joy-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeet-joy-tw sangeet-joy-tw merged commit 70e3a6b into XeroAPI:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants