Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PETOSS 536 | Commitizen & husky changes #626

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

# JetBrains generated files
.idea
/node_modules
node_modules/
9 changes: 9 additions & 0 deletions .husky/prepare-commit-msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
if [ ! -d "node_modules" ]; then
echo "It looks like you have not run 'npm install', please run 'npm install' before commiting..."
exit 1
fi

exec < /dev/tty && npx cz --hook || {
echo "aborting commit"
exit 1
}
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ In Release (used for one or more SDKs)
## Code Generators
We are using [OpenAPI generator](https://github.com/OpenAPITools/openapi-generator) along with these OAS yaml files to generate our new SDKs.

## Contribution guide
* Please run ` npm install ` in root directory before working in this repo.
* It will enable commit linting in your local
* run ``` git commit ``` before making any commit
* You will be prompted with a interactive commit cli before each commit to keep the commit messages structured to maintain repo's release management process.
![alt text](images/cz-cli.png)
* You will only be able to commit through your integrated or local terminal and no other GUI.
* We are using [commitizen cz-cli](https://github.com/commitizen/cz-cli) for our commit ruling set up.

## Preview
There are lots of tools available for viewing and editing OpenAPI descriptions in a nicely formatted way. A popular tool is SwaggerHub - a version of which is [hosted here](https://app.swaggerhub.com/home).

Expand Down
Binary file added images/cz-cli.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading