add pystxm operations #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitignore # xicam/spectral/__init__.py
# Conflicts: # .gitignore # setup.py # xicam/spectral/__init__.py # xicam/spectral/ingestors/__init__.py
# Conflicts: # xicam/spectral/__init__.py
# Conflicts: # xicam/spectral/projectors/__init__.py # xicam/spectral/stages/__init__.py
# Conflicts: # xicam/spectral/operations/decomposition.py
ronpandolfi
reviewed
Feb 5, 2021
ihumphrey
reviewed
Feb 5, 2021
| @@ -66,6 +66,7 @@ def ingest_cxi(paths): | |||
| sorted_entry_list = sorted(h5_entry_dict.items(), key=lambda item: item[1]) | |||
| # TODO check if energies are "continuous" or have interruptions | |||
| # the removal of last for entries is only temporary due to the example dataset | |||
| # FIXME what to do if some energies are 'out of range'? | |||
There was a problem hiding this comment.
refer to nx tycho to see if we can put these reference energies in a different field (may have to extend the spec)
There was a problem hiding this comment.
heuristics, or acquisition-side definition of the reference energies
(just writing these comments for later notes - fine to keep this in for now)
ronpandolfi
reviewed
Feb 5, 2021
ronpandolfi
reviewed
Feb 5, 2021
| @@ -42,10 +44,16 @@ def __init__(self): | |||
| super(SpectralBase, self).__init__() | |||
|
|
|||
| def treatment_kwargs(self, workflow): | |||
| intent_name = ['hyperspectral_data', 'ptychography data', 'IR maps'] | |||
There was a problem hiding this comment.
@ronpandolfi what's the best way to attribute scientific meaning through intents?
ronpandolfi
reviewed
Feb 5, 2021
| self.add_operation(denoise) | ||
| self.add_operation(calc_OD) | ||
| self.add_operation(lstsq_fit) | ||
| # self.auto_connect_all() | ||
| #connect one operation's output with another operation's input | ||
| # self.add_link() | ||
|
|
There was a problem hiding this comment.
Add connections, move to Xi-CAM.STXM
ronpandolfi
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic operation/workflow example for discussion