Remove preallocation of memory in cell linked list #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was currently allocating memory for all cells even is the body particles are sparse within the bounding box. This led to a huge amount of memory wasted, sometimes intractable for complex models (e.g. 100GB for only 2M created)
FabienPean-Virtonomy
changed the title
Xiangyu-Hu
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was currently allocating memory for all cells even is the body particles are sparse within the bounding box. This led to a huge amount of memory wasted, sometimes intractable for complex models (e.g. 100GB for only 2M created)