Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiangyu/combining injection and deletion #659

Closed
wants to merge 2 commits into from

Conversation

Xiangyu-Hu
Copy link
Owner

Combine particle injection and deletion in bi-drectional buffer so that it is identified from particle disposer class.

@Xiangyu-Hu
Copy link
Owner Author

I decide to close the pull request, as it seems not a good idea to mix the copy direction.
That is mixing the copy to and from the end of real particles, which is quite dangerous for memory conflict issue.
May be the better way to improve efficiency is to combine the injection or deletion in all buffers together in corresponding single loop.

@Xiangyu-Hu Xiangyu-Hu closed this Sep 17, 2024
@Xiangyu-Hu Xiangyu-Hu deleted the xiangyu/combining_injection_and_deletion branch September 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant