Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON-15199: Add cplane parameters to Onload CRD #122

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ivatet-amd
Copy link
Collaborator

@ivatet-amd ivatet-amd commented Jan 11, 2024

The default value is -K (to emit the logs to the kernel buffer viewable with dmesg).

The new field resides in the OnloadSpec but is technically used only within the Onload Device Plugin.

Tested in a virtualised cluster, and also added test coverage for the control plane package and controller.

Need to rebase on top of #120.

@ivatet-amd ivatet-amd force-pushed the reviews/iteterev/ON-15199 branch from e809b56 to 5eea310 Compare January 12, 2024 08:58
@ivatet-amd ivatet-amd marked this pull request as ready for review January 12, 2024 09:03
@ivatet-amd ivatet-amd requested a review from a team as a code owner January 12, 2024 09:03
api/v1alpha1/onload_types.go Outdated Show resolved Hide resolved
controllers/onload_controller_test.go Outdated Show resolved Hide resolved
api/v1alpha1/onload_types.go Show resolved Hide resolved
@ivatet-amd ivatet-amd force-pushed the reviews/iteterev/ON-15199 branch from 5eea310 to 1600859 Compare January 12, 2024 09:51
@ivatet-amd ivatet-amd requested review from tcrawley-xilinx and a team January 12, 2024 09:51
@ivatet-amd
Copy link
Collaborator Author

Thanks @tcrawley-xilinx for the prompt review. 👍

@ivatet-amd ivatet-amd force-pushed the reviews/iteterev/ON-15199 branch from 1600859 to f6b8691 Compare January 12, 2024 15:37
@ivatet-amd ivatet-amd force-pushed the reviews/iteterev/ON-15199 branch from f6b8691 to eb9bcad Compare January 12, 2024 16:07
@ivatet-amd ivatet-amd force-pushed the reviews/iteterev/ON-15199 branch from eb9bcad to f08d400 Compare January 12, 2024 16:11
@ivatet-amd ivatet-amd merged commit a6d199b into master Jan 12, 2024
10 checks passed
@ivatet-amd ivatet-amd deleted the reviews/iteterev/ON-15199 branch January 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants