[RWRoute] Yet more cleanup #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
…ving Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com> Conflicts: src/com/xilinx/rapidwright/rwroute/PartialRouter.java
Signed-off-by: Eddie Hung <eddie.hung@amd.com> Conflicts: src/com/xilinx/rapidwright/rwroute/PartialRouter.java src/com/xilinx/rapidwright/rwroute/RWRoute.java
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
preservedMap and nodesMap Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: eddieh-xlnx <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
…arer Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Conflicts: src/com/xilinx/rapidwright/rwroute/RouteNode.java
Conflicts: src/com/xilinx/rapidwright/rwroute/RWRoute.java src/com/xilinx/rapidwright/rwroute/RouteNode.java src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java src/com/xilinx/rapidwright/rwroute/RouteNodeType.java
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Conflicts: src/com/xilinx/rapidwright/rwroute/Connection.java src/com/xilinx/rapidwright/rwroute/GlobalSignalRouting.java src/com/xilinx/rapidwright/rwroute/PartialRouter.java src/com/xilinx/rapidwright/rwroute/RWRoute.java src/com/xilinx/rapidwright/rwroute/RouteNode.java src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java src/com/xilinx/rapidwright/rwroute/RouteNodeInfo.java src/com/xilinx/rapidwright/rwroute/RouteNodeType.java
eddieh-xlnx
commented
Nov 18, 2024
Signed-off-by: eddieh-xlnx <eddie.hung@amd.com>
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
clavin-xlnx
approved these changes
Nov 19, 2024
| protected final static int MAX_OCCUPANCY = 256; | ||
| protected final float[] presentCongestionCosts; | ||
|
|
||
| protected static int getTileCount(Design design) { |
There was a problem hiding this comment.
Should we add this to the Device object?
There was a problem hiding this comment.
Yes, I think that's a good idea. Specifically, I think we should update the documentation to state that Tile.getUniqueAddress() should not exceed a new method that is Tile.getMaxUniqueAddress().
Let's not hold up this PR until the next release though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(repeat of #1072)
RouteNodereduced from 80 bytes to 64 bytesRouteNodeGraph.{preservedMap,nodesMap}(no longerConcurrentHashMap-s) values' to be arrays to be sized no larger than number of base wires of its tileRouteNodeType.INACCESSIBLEto prevent unnecessary explorationResults for just the RWRoute wall time and the number of nodes it popped, for the FPGA24 Routing Contest benchmarks.
2.1% reduction in total wall time, despite 2.2% increase in number of nodes popped.