Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDIFTools] Adds support for lower hierarchy connection #944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[EDIFTools] Adds support for lower hierarchy connection #944

wants to merge 1 commit into from

Conversation

clavin-xlnx
Copy link
Member

Adds support for the case where the connection to be made is lower in the hierarchy (descendant) rather than a parent.

@clavin-xlnx
[EDIFTools] Adds support for lower hierarchy connection
681c4f8 
Signed-off-by: Chris Lavin <chris.lavin@amd.com>
eddieh-xlnx
eddieh-xlnx reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@eddieh-xlnx eddieh-xlnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be kind enough to demonstrate this with a test?

There's a pretty basic test at TestEDIFTools.testConnectPortInstsThruHier() that you duplicate or parameterize?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddieh-xlnx eddieh-xlnx eddieh-xlnx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clavin-xlnx @eddieh-xlnx