CR-1178512 Fix xrt setup script hang on CSH shell #8493
Merged
+14
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <rbramand@amd.com>
rbramand-xilinx
requested review from
chvamshi-xilinx
and removed request for
rozumx
stsoe
approved these changes
Oct 4, 2024
chvamshi-xilinx
approved these changes
Oct 4, 2024
vipangul
pushed a commit
to vipangul/XRT
that referenced
this pull request
Oct 4, 2024
Signed-off-by: rbramand <rbramand@amd.com> Co-authored-by: rbramand <rbramand@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When xrt setup script is sourced on csh shell sometimes a hang is seen, this is because of the use of lsof command to get path to script. Made changes to get script path using simpler commands instead.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Reported by user, as described in CR a hang is seen when running setup.csh script. This probably might not be hang but lsof command taking time.
How problem was solved, alternative solutions (if any) and why they were rejected
Made changes to get script path when both script is either sourced or executed
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested on csh shell on centos and ubuntu machines and the script works as expected.
Documentation impact (if any)
NA