Fix (scaling)!: clamp to avoid inf/nan in forward/backward #1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Restrict scaling with log op could cause inf/nan in the forward pass and/or in the gradients.
Changes Made in this PR
Applying a restriction before (new behaviour) and after (existing behaviour) helps avoiding that.
Testing Summary
Add tests for standalone and runtime scaling to check inf/nan in forward/backwards.
Risk Highlight
This is a breaking change. Old checkpoints will work, new QAT/PTQ runs could produce different results from before.
Checklist
dev
branch.