[DRAFT] Feat cailey sgd #1127
Draft
[DRAFT] Feat cailey sgd #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
reviewed
Dec 13, 2024
| @@ -166,3 +183,86 @@ def apply_exact_had_to_linear(module, had_dim=-1, output=False): | |||
|
|
|||
| def is_pow2(n): | |||
| return (n & (n - 1) == 0) and (n > 0) | |||
|
|
|||
|
|
|||
| hadamard_string_16 = """++++++++++++++++ | |||
There was a problem hiding this comment.
This is temporal code. These matrices will be included in hadamard.pt, when the PR is in merge state.
Giuseppe5
reviewed
Dec 13, 2024
src/brevitas/graph/equalize.py
Outdated
| regions: List[Region] = [] | ||
| self.find_module(model, regions) | ||
| if len(regions) > 0: | ||
| _apply_rotate(model, regions) | ||
| return model | ||
|
|
||
|
|
||
| def _apply_rotate_fused_rotations( |
There was a problem hiding this comment.
We don't need an entire new function
Giuseppe5
reviewed
Dec 13, 2024
| @@ -0,0 +1,197 @@ | |||
| # coding=utf-8 | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
Add a reference to the code origin
Giuseppe5
reviewed
Dec 13, 2024
src/brevitas_examples/llm/main.py
Outdated
| @@ -49,7 +53,7 @@ def set_seed(seed): | |||
| torch.random.manual_seed(seed) | |||
|
|
|||
|
|
|||
| def fused_rotation_no_fx(model, calibration_loader, args): | |||
| def fused_rotation_no_fx(model, calibration_loader, args, fuse_rotations: bool = False): | |||
There was a problem hiding this comment.
fuse_rotation -> optimize_rotation
There was a problem hiding this comment.
The matrices can be kept unfused, even if they are no optimized (even if this is not leveraged at any point), so this name seems more general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Changes Made in this PR
Testing Summary
Risk Highlight
Checklist
devbranch.