Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (notebook): increase atol for asserts #759

Merged
merged 1 commit into from
Nov 15, 2023
+3 −4
Merged

Fix (notebook): increase atol for asserts #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions notebooks/quantized_recurrent.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@
"from torch.nn import RNN\n",
"from brevitas.nn import QuantRNN\n",
"from brevitas import config\n",
"ATOL = 1e-6\n",
"\n",
"config.IGNORE_MISSING_KEYS = True\n",
"torch.manual_seed(123456)\n",
Expand All @@ -648,12 +649,10 @@
"\n",
"# Generate random input\n",
"inp = torch.randn(5, 2, 10)\n",
"\n",
"# Check outputs are the same\n",
"assert torch.isclose(quant_rnn(inp)[0], float_rnn(inp)[0]).all().item()\n",
"\n",
"assert torch.allclose(quant_rnn(inp)[0], float_rnn(inp)[0], atol=ATOL)\n",
"# Check hidden states are the same\n",
"assert torch.isclose(quant_rnn(inp)[1], float_rnn(inp)[1]).all().item()"
"assert torch.allclose(quant_rnn(inp)[1], float_rnn(inp)[1], atol=ATOL)"
]
},
{
Expand Down
Loading