-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding FP8 weight export #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costigt-dev
force-pushed
the
feat/export_fp8
branch
from
March 27, 2024 09:00
e2fc20e
to
a8b6a55
Compare
costigt-dev
force-pushed
the
feat/export_fp8
branch
from
April 8, 2024 11:01
a8b6a55
to
6552b68
Compare
Giuseppe5
reviewed
Apr 8, 2024
costigt-dev
force-pushed
the
feat/export_fp8
branch
from
April 12, 2024 09:53
6552b68
to
98bc90f
Compare
Giuseppe5
reviewed
Apr 16, 2024
Giuseppe5
reviewed
Apr 16, 2024
Giuseppe5
reviewed
Apr 16, 2024
…eightQuantProxyHandlerMixin to be more consistent
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
reviewed
May 28, 2024
nickfraser
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
To enable export of OCP FP8 weights to onnx.
Changes Made in this PR
Float specific export mixins and handlers created, changes made to retrieve exponent and mantissa bit widths etc.
Testing Summary
Tests still being written
Risk Highlight
Makes changes to FloatQuant and the proxy class of FloatWeightBase which might be used elsewhere
Uses OCP fp8 types in pytorch which only work with version 2.1 onwards so this functionality won't work for some pytorch versions still within our test suite.
Relies on: #919 and is using placeholder code at present.
Checklist
dev
branch.Future Work