Fix/remove-numel - Remove numel is zero check from context manager exit method #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
torch.empty and torch.numel don't work as originally expected although this code path was unlikely to be triggered in the original scenario this context manager was added to resolve
Changes Made in this PR
Removed the contents of the exit method in the load_quant_model context manager as the method to detect if the newly added biases were corrected won't work as intended.
Also replaced empty with zeros so the bias layer won't affect anything if unused.
Testing Summary
Risk Highlight
Checklist
dev
branch.Future Work