Feature/validation steps #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added files for validating finn-examples builds
Build verification by appending to Python sys.path and importing functions
jmonks-amd
commented
Jul 23, 2024
…y13/finn-examples into feature/validation_steps
Clean up verification build files
|
Looks good to me! |
auphelia
reviewed
Jul 30, 2024
| platforms_to_build = zynq_platforms + alveo_platforms | ||
|
|
||
|
|
||
| def custom_step_update_model(model, cfg): |
There was a problem hiding this comment.
Maybe we can move this function to a central point, since it is used in multiple places. Either to finn or to qonnx, we can sync offline about this.
… validation steps
|
Due to bad commits that resulted in the branch becoming unworkable (older commits being treated as newer, unable to revert as git believed no changes had been made), commits from this branch were cherry picked into feature/validation_steps_clean. You can view the pull request of this new branch here: #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables optional verification for all finn-examples models. The verification is performed by running the model against a known input, then comparing the produced output against a known output to check if the values match, returning a success or fail depending on the result. The verification steps are run at various points throughout the build, after its corresponding build step has completed.
The verification can be enabled by setting the following environment variables:
Once these variables are set, the FINN build can be run and verification will be used within the build.
This PR depends on Xilinx/finn#1140