Testing/jenkins integration #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
This reverts commit 6003306.
…ew directory Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
…r more boards to be parameterized Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
…y board marker Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
…djust test scripts to workaround these changes Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
… from the pipeline Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
The fpgadataflow tests were placed in their own stage with their own build parameter as the test takes longer than a day to run.
This means that this suite cannot sensibly be used in daily CI test runs.
Some notes on the stages and their setup:
- the when{} block is used as an 'if' statement, checking if a certain input parameter to the pipeline has been set. By default - the fpgadataflow stage will not run unless explicitly set to true by the tester/CI system
- FINN_HOST_BUILD_DIR is set to a unique directory per stage for ease of use/test cleanup
- catchError is used in order to allow the pipeline to continue to possible future stages if a stage along the way fails. Otherwise the first failed stage found would end the test run
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
…st scripts Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
…d is offline Signed-off-by: Fionn O'Donohoe <fionno@xilinx.com>
auphelia
requested changes
Aug 10, 2023
[CI] Fix bug with build parameters and result flags sharing common names
…mmands Jenkins unexpectedly trims trailing spaces from env variables. This leads to badly formed inputs for docker. Appending an extra space solves this issues and causes no further problems.
|
@fionnodonohoe-xlnx @auphelia Hello, can I get information about Kria KV260? Can we use this board for FINN? Do we submit this information to the FINN documentation if it is available? |
added 5 commits
October 9, 2023 11:09
jmonks-amd
force-pushed
the
testing/jenkins-integration
branch
4 times, most recently
from
46767dd
to
1787ec5
Compare
jmonks-amd
force-pushed
the
testing/jenkins-integration
branch
from
1787ec5
to
07e3b39
Compare
jmonks-amd
force-pushed
the
testing/jenkins-integration
branch
from
8d66d9f
to
1bf20d5
Compare
auphelia
approved these changes
Oct 24, 2023
|
Thanks @fionnodonohoe-xlnx and @johnnoel-xlnx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes include:
When testing on HW, various issues were seen:
A workaround was put in just to get some tests passing - so a temporary hack script is seen in this PR.
I removed this script when I correctly adjusted the test data here: 61cba65 and 10d34b5