Revert wrong (?) diff to upstream #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
force-pushed
the
matthias.revert_LinalgNamedStructuredOps
branch
from
12e31a1 to
453ec2f
Compare
ljfitz
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
I guess so too. When I saw changes in #103 still I thought they were all due to the same issue as llvm@a590ff5 but it looks like I missed this. Thanks for correcting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces our diff with upstream. I couldn't find any commit on our side that introduced this change, so maybe it was a merge conflict issue?