[MLIR][Bufferization] BufferResultsToOutParams: Add option to add attribute to output arguments #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
TinaAMD
reviewed
Feb 28, 2024
mlir/test/Transforms/buffer-results-to-out-params-add-result-attr.mlir
Outdated
Show resolved
Hide resolved
mlir/test/Transforms/buffer-results-to-out-params-add-result-attr.mlir
Outdated
Show resolved
Hide resolved
TinaAMD
approved these changes
Feb 28, 2024
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
mgehre-amd
changed the base branch from
users/mgehre/spr/feature/fused-ops.mlirbufferization-bufferresultstooutparams-add-option-to-add-attribute-to-output-arguments
to
feature/fused-ops
mgehre-amd
deleted the
users/mgehre/spr/mlirbufferization-bufferresultstooutparams-add-option-to-add-attribute-to-output-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pass option
add-result-attrthat will make the pass add the attribute{bufferize.result}to each argument that was converted from a result.To be able to test this, the pass option was added to the tablegen.
And then the existing manual option struct
BufferResultsToOutParamsOptionswas renamed to
BufferResultsToOutParamsOptsto not conflict.