asan: replace used python in mlir lit.cfg with shim script #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exchanges the used Python executable inside the MLIR LIT test suite, when the build is configured for utilizing ASan. The executable is replaced with a shim script, which preloads the necessary ASan shared object file as it did before, but additionally exhibits two benefits:
not
, which are prepended to the original statement containing theLD_PRELOAD
env definition. Having environment definitions in the middle of a command line is syntactically illegal.LD_PRELOAD=$(/usr/bin/clang++-17' '-print-file-name=libclang_rt.asan-x86_64.so)' python (...)
LIT_USE_INTERNAL_SHELL=0
, but might not be desired for compatibility/stability reasons.