PDLL: Fix crash when logical not doesn't apply to call; prepare precedence #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
changed the title
mgehre-amd
force-pushed
the
matthias.pdl_builtin
branch
from
a30a601 to
a309fe1
Compare
mgehre-amd
force-pushed
the
matthias.pdll_neg_precedence
branch
from
717c6bb to
9d3b31f
Compare
mgehre-amd
force-pushed
the
matthias.pdll_neg_precedence
branch
from
9d3b31f to
cc9994e
Compare
ehsan-toosi
approved these changes
Mar 7, 2024
mgehre-amd
force-pushed
the
matthias.pdll_neg_precedence
branch
from
cc9994e to
0be8938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates precedence between expressions, preparing for all the expressions that will come later.
While doing this, I noticed that
!has a bug when it's not followed by a function call. I added two tests and a check for that.