Fail to match if type cannot convert (instead of crash)

Xilinx · Mar 15, 2024 · 9ea886f · 9ea886f
1 parent 2fa0e68
commit 9ea886f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/Conversion/ONNXToTOSA/Tensor/Constant.cpp b/src/Conversion/ONNXToTOSA/Tensor/Constant.cpp
@@ -44,6 +44,10 @@ class ONNXConstOpLoweringToTOSA : public OpConversionPattern<ONNXConstantOp> {
           op, "tosa.const does not support non-tensor types");
     }
     Type resultType = getTypeConverter()->convertType(op.getResult().getType());
+    if (! resultType) {
+      return rewriter.notifyMatchFailure(
+          op, "tosa.const does not support the requested type");
+    }
     rewriter.replaceOpWithNewOp<mlir::tosa::ConstOp>(
         op, resultType, currentAttr.cast<ElementsAttr>());
     return success();