[FXML-4647] Add ONNX operator version as trait of dialect #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferry-AMD
force-pushed
the
corentin.add_onnx_version_to_dialect
branch
from
3e5a003 to
f8da469
Compare
cferry-AMD
force-pushed
the
corentin.add_onnx_version_to_dialect
branch
from
f8da469 to
1e4e8e2
Compare
cferry-AMD
commented
Jun 12, 2024
TinaAMD
reviewed
Jun 12, 2024
mgehre-amd
approved these changes
Jun 12, 2024
cferry-AMD
commented
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the op definition (.td) to add the op version as an explicit trait. Downstream passes can use this trait and not make assumptions on the ONNX-MLIR opset version.