Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNXToTosa: MaxPoolSingleOut: Support dilations whens they are 1 #60

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mgehre-amd
Copy link
Collaborator

Up to now, we only supported MaxPool when the dilations attribute is absent, which means that the default dilations of 1 in each dimension is used.
Now we also allow when the dilations are explicitly specified as 1.

@mgehre-amd mgehre-amd requested a review from roberteg16 March 12, 2024 11:05
@mgehre-amd mgehre-amd force-pushed the matthias.max_pool_dilation_1 branch from 2834b19 to 9189bd7 Compare March 12, 2024 11:06
Copy link

@roberteg16 roberteg16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@mgehre-amd mgehre-amd enabled auto-merge March 12, 2024 11:19
@mgehre-amd mgehre-amd merged commit 2fa0e68 into feature/onnx-to-tosa Mar 12, 2024
6 checks passed
@mgehre-amd mgehre-amd deleted the matthias.max_pool_dilation_1 branch March 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants