fixing bad criterion fds adding more reports.

.github/workflows/ci.yml

@@ -134,7 +134,7 @@ jobs:
                 run: "echo \"${{ env.VALGRIND_SUPPRESSIONS }}\" > valgrind.supp"
 
             -   name: "Run valgrind"
-                run: "[ -f \"${{ env.UNIT_TESTS }}\" ] && valgrind -s --leak-check=full --track-origins=yes --read-var-info=yes --trace-children=yes --show-leak-kinds=all --read-inline-info=yes --errors-for-leak-kinds=all --track-fds=yes --show-reachable=yes --gen-suppressions=all --suppressions=valgrind.supp ${{ env.UNIT_TESTS }} 2>${{ env.VALGRIND_REPORTS }}"
+                run: "[ -f \"${{ env.UNIT_TESTS }}\" ] && CRITERION_NO_EARLY_EXIT=1 valgrind -s --leak-check=full --track-origins=yes --read-var-info=yes --trace-children=yes --show-leak-kinds=all --read-inline-info=yes --errors-for-leak-kinds=all --track-fds=yes --expensive-definedness-checks=yes --gen-suppressions=all --suppressions=/usr/libexec/valgrind/default.supp --suppressions=valgrind.supp ${{ env.UNIT_TESTS }} --verbose 2>${{ env.VALGRIND_REPORTS }}"
 
             -   name: "Analyze valgrind report"
                 run: |
@@ -143,7 +143,7 @@ jobs:
                     block=""
                     while IFS= read -r line; do
                         if [[ "${block}" != "" ]]; then
-                            if [[ $(echo "${line}" | grep '^==.*== $') ]]; then
+                            if [[ $(echo "${line}" | grep '^==.*== $') && $(echo "${block}" | grep '==.*==    by 0x.*: stdpipe_options (in /usr/local/lib/libcriterion.so.3.2.0)') == "" && $(echo "${block}" | grep '==.*== Open file descriptor .*: /dev/shm/bxf_arena_.* (deleted)') == "" ]]; then
                                 echo "::error title=Valgrind Error::${block}"
                                 block=""
                                 status=1
@@ -159,7 +159,19 @@ jobs:
                             block="${line}"
                         elif [[ $(echo "${line}" | grep '^==.*== Open file descriptor .*: .*$') ]]; then
                             block="${line}"
-                        elif [[ $(echo "${line}" | grep '^==.*== LEAK SUMMARY:.*$') ]]; then
+                        elif [[ $(echo "${line}" | grep '^==.*== Invalid free().*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Mismatched free() / delete / delete \[\].*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Syscall param .* points to uninitialised byte(s).*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Source and destination overlap in .*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Argument '.*' of function .* has a fishy (possibly negative) value: .*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== .*alloc() with size 0$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Invalid alignment value: .* (should be power of 2)$') ]]; then
                             block="${line}"
                         fi
                     done < ${{ env.VALGRIND_REPORTS }}

README.md

@@ -124,6 +124,12 @@ possible, then the valgrind tests will make sure that the code you wrote, both
 the tests and the actual implementations, are not leaking at all. Valgrind will
 look for :
 - memory leaks (including inside `fork()` children),
+- invalid `free()`, `delete` and `delete[]`,
+- invalid system call params (uninitialised bytes),
+- overlaping for memory operations (`memmove`, `memcpy`, ...),
+- `fishy` arguments (possibly negative values),
+- invalid arguments for `*alloc` functions (`*alloc(0)`),
+- invalid alignment value,
 - unclosed file descriptor,
 - invalid read/writes,
 - conditionnal jumps or move depends on uninitialised value(s),