forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monthly Merge from dev upgrade branch to master #761
Open
benjamin202410
wants to merge
558
commits into
master
Choose a base branch
from
dev-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* internal/flags: use filepath.Clean instead of path.Clean * internal/flags: fix windows pipe issue * internal/flags: modify test for windows * internal/flags: use backticks, fix test
…thereum#28692) Certain flags, such as `--rpc.txfeecap` currently do not have an env-var auto-generated for them. This change adds three missing cli flag types to the auto env-var helper function to fix this.
cmd: migrate to urfave/cli/v2
Co-authored-by: liam.lai <liam.lai@us>
Devnet bootnode
fix typo and local script
all: use http package to replace http method names
all: replace strings.Replace with string.ReplaceAll
implement EIP-3651(warm coinbase)
core/vm: improve EVM reusability
Package crypto works with or without cgo, which is great. However, to make it work without cgo required setting the build tag `nocgo`. It's common to disable cgo by instead just setting the environment variable `CGO_ENABLED=0`. Setting this environment variable does _not_ implicitly set the build tag `nocgo`. So projects that try to build the crypto package with `CGO_ENABLED=0` will fail. I have done this myself several times. Until today, I had just assumed that this meant that this package requires cgo. But a small build tag change will make this case work. Instead of using `nocgo` and `!nocgo`, we can use `!cgo` and `cgo`, respectively. The `cgo` build tag is automatically set if cgo is enabled, and unset if it is disabled.
…arameters (ethereum#19577) * Removed comment section referring to Cloudflare's bn curve parameters * Added comment to clarify the nature of the parameters * Changed value of xi to i+9
…grade Release br v2.4.6 beta1 merge back to dev upgrade
benjamin202410
temporarily deployed
to
devnet
December 28, 2024 04:17 — with
GitHub Actions
Inactive
benjamin202410
temporarily deployed
to
mainnet
December 28, 2024 04:18 — with
GitHub Actions
Inactive
benjamin202410
temporarily deployed
to
testnet
December 28, 2024 04:18 — with
GitHub Actions
Inactive
benjamin202410
temporarily deployed
to
devnet
December 28, 2024 04:18 — with
GitHub Actions
Inactive
upgrade the core package for reorg
Co-authored-by: liam.lai <liam.lai@us>
Co-authored-by: liam.lai <liam.lai@us>
benjamin202410
temporarily deployed
to
devnet
December 30, 2024 06:01 — with
GitHub Actions
Inactive
Co-authored-by: liam.lai <liam.lai@us>
Co-authored-by: liam.lai <liam.lai@us>
add readme changes to support xdpos2 protocol from block 0
New devnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Monthly Merge from dev upgrade branch to master
This is including eip-1559 change.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that