core/rawdb: separate raw database access to own package #788

JukLee0ira · 2025-01-02T03:28:54Z

Proposed changes

Move the functions from the file core/database_util.go to the rawdb package.

ref：
ethereum#16666
ethereum#19345

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)
Regular KTLO or any of the maintaince work. e.g code style
CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
Tested the backwards compatibility.
Tested with XDC nodes running this version co-exist with those running the previous version.
Relevant documentation has been updated as part of this PR
N/A

cmd/XDC/dao_test.go

core/rawdb/accessors_chain.go

core/rawdb/interfaces.go

core/rawdb/accessors_indexes.go

gzliudan · 2025-01-16T09:50:02Z

core/rawdb/accessors_chain.go

+// ReadTd retrieves a block's total difficulty corresponding to the hash, nil if
+// none found.
+func ReadTd(db ethdb.Reader, hash common.Hash, number uint64) *big.Int {
+	data, _ := db.Get(append(append(append(headerPrefix, encodeBlockNumber(number)...), hash[:]...), headerTDSuffix...))


use ReadTdRLP

core/rawdb/accessors_indexes.go

core/rawdb/accessors_metadata.go

gzliudan · 2025-01-17T11:50:37Z

please try to reduce the call of append

core/rawdb/accessors_metadata.go

JukLee0ira force-pushed the Migrate-to-rawdb branch 9 times, most recently from e8f4e36 to 773f838 Compare January 3, 2025 09:41

JukLee0ira force-pushed the Migrate-to-rawdb branch from 68c8256 to abc28c9 Compare January 15, 2025 09:15