add HTTP referer header for resource requests #400
Conversation
src/url.rs
Outdated
| @@ -79,6 +79,17 @@ pub fn parse_data_url(url: &Url) -> (String, String, Vec<u8>) { | |||
| (media_type, charset, blob) | |||
| } | |||
|
|
|||
| pub fn referer_url(url: Url) -> Url { | |||
| let mut url = url.clone(); | |||
| // https://httpwg.org/specs/rfc9110.html#field.referer | |||
There was a problem hiding this comment.
I think putting "Spec: " or "Reference: " before the URL could be a good way to make it more readable, otherwise it's just a commented out URL. I try not to put them myself, since URLs tend to become 404/301 sometimes, and then it'll have to be updated.
There's this file here https://github.com/Y2Z/monolith/blob/master/docs/references.md that I created to keep all used references, maybe we could move it there, what do you think?
There was a problem hiding this comment.
Just add a Spec: prefix.
It's nice to have internal documentation and refer to it, but in case when ref leads just to another/external ref, in my vision, it doesn't make sense. Anyway in case external link "died" one have to update it no matter its place in the source code.
src/url.rs
Outdated
| pub fn referer_url(url: Url) -> Url { | ||
| let mut url = url.clone(); | ||
| // https://httpwg.org/specs/rfc9110.html#field.referer | ||
| // MUST NOT include the fragment and userinfo components of the URI |
There was a problem hiding this comment.
"MUST NOT" sounds a bit too commanding, as if somebody's shouting at you. "Must not" would be nicer and easier to read.
src/url.rs
Outdated
| @@ -79,6 +79,17 @@ pub fn parse_data_url(url: &Url) -> (String, String, Vec<u8>) { | |||
| (media_type, charset, blob) | |||
| } | |||
|
|
|||
| pub fn referer_url(url: Url) -> Url { | |||
There was a problem hiding this comment.
Maybe something like get_referer_url, format_referer_url, or url_to_referer_url would be more descriptive? Just to be more consistent with function names in that file.
| @@ -46,7 +46,7 @@ mod passing { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn removesempty_fragment_and_keeps_empty_query() { | |||
| fn removes_empty_fragment_and_keeps_query() { | |||
There was a problem hiding this comment.
Embarrassing, but typos aren't as shameful when they're in tests 😄
tests/url/referer_url.rs
Outdated
|
|
||
| #[test] | ||
| fn preserve_original() { | ||
| let u: Url = Url::parse("https://somewhere.com/font.eot#iefix").unwrap(); |
There was a problem hiding this comment.
nit: naming it url and referer_url might make it a bit easier to read for whoever sees it for the first time, u can be "user"
Nice to have it ;), thanks |
to mimic more-browser-like-behavior on loading page resources. Sometimes their response depends on
refererheader.e.g. I faced with the problem to load font data for page, because it was protected for "direct" loading, got
401, but with therefererheader it looks like request from browser.