Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling vendored OpenSSL while building #406

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Sep 3, 2024

Hey, I'm the maintainer of the monolith package for Arch Linux 👋

I saw that in the latest version OpenSSL is being linked statically, which is something that I wanted to avoid for the package. I was able to do it by using OPENSSL_NO_VENDOR=1 flag but thought it would be better to add a feature flag for it so that I can do --no-default-features next time :)

Cheers!

@snshn
Copy link
Member

snshn commented Sep 5, 2024

Hey Orhun,

thank you for maintaining the Arch package and making this PR!

OpenSSL is a real pain in the neck to deal with, I'm currently trying to find the best combination of solutions to make everyone happy, and it's tricky due to dealing with cross-platform issues and different architectures.

I'll go ahead and merge this PR for it to be available in the next release, it may be useful for other package maintainers and users as well. I may have to ditch static linking if it creates any more issues, it's more of an experiment, and I hope it was a step in the right direction (many people were having issues with the binary not finding their library).

@snshn snshn merged commit 65ac5c3 into Y2Z:master Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants