[PC-106] SMS 인증 시스템 구현 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lujaec
approved these changes
Jan 2, 2025
| * | ||
| * @return 6자리 난수 | ||
| */ | ||
| public int generate() { |
There was a problem hiding this comment.
현재 코드상으로 생성되는 난수의 범위는 100000부터 999999까지로 확인됩니다. 하지만, 문자 인증을 할 때는 숫자 문자열을 입력하는 것이기 때문에 "008712" 같은 0으로 시작하는 경우도 포함하여 숫자 문자열을 전달하는 것이 조금 더 바람직해보입니다.
| /** | ||
| * 테스트를 위한 초기화 메서드 | ||
| */ | ||
| public void initForTest(String apiKey, String apiSecret, String fromNumber, |
There was a problem hiding this comment.
테스트 코드를 위해서 운영 코드에 별도의 메서드를 추가하는 것은 코드의 일관상이 떨어지는 것 같습니다.
| @Service | ||
| @RequiredArgsConstructor | ||
| public class SmsSenderService { | ||
| @Value("${coolsms.apikey}") |
There was a problem hiding this comment.
RequiredArgsConstructor는 private final인 필드에 대해서 생성자를 생성하는 것으로 알고있는데, final이 붙은 필드가 없어서 어노테이션이 의미가 없어진 것 같습니다 .혹시 다른 의도가 있으셨나요 ?
| * | ||
| * @param phoneNumber 인증 번호를 받을 핸드폰 번호 | ||
| */ | ||
| public void sendAuthCodeTo(String phoneNumber) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
PC-106
✨ 작업 내용
✅ 체크리스트
🎃 새롭게 알게된 사항
📋 참고 사항