Dockerize the project #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will drastically improve the reproducibility and installation of this toolkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your amazing project.
However, while @Lorenzoantonelli and I were trying to actually run your project in order to do some evaluation using the ROUGE metrics, we encountered many errors in the dependencies.
That's why we wanted to create a Docker container for the project: this will improve the reproducibility and installation of this toolkit for future users.
The main issues were there when trying to install it directly from pip instead of cloning the repository. This resulted in errors to install the ROUGE tool.
Then, I had to find this commit to understand how to actually install it. In addition to other Perl requirements.
In our opinion, this makes this great project much more straightforward to use.