Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it work for alpine and centos based images, too #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make it work for alpine and centos based images, too #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57549e2
make it work for alpine and centos based images, too
dsteinkopf Jun 26, 2021
bd2c1b0
improve error handling for hash creation
dsteinkopf Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions docker_push_latest_if_changed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#!/usr/bin/env python3.6
#!/usr/bin/env python3
import argparse
import hashlib
import subprocess
import random
from typing import NamedTuple
from typing import Optional
from typing import Sequence
Expand Down Expand Up @@ -191,7 +192,25 @@ def _get_commands_hash(image_uri: str) -> str:


def _get_packages_hash(image_uri: str) -> str:
packages = _run_in_image(image_uri, ('dpkg', '-l'))
try:
packages = _run_in_image(image_uri, ('dpkg', '-l'))
except subprocess.CalledProcessError as oserr:
if oserr.returncode != 127:
print(f'failed. returncode={oserr.returncode}. stderr:\n{oserr.stderr}')
else:
# retry - maybe we have an alpine based image
try:
packages = _run_in_image(image_uri, ('apk', 'list'))
except subprocess.CalledProcessError as oserr:
if oserr.returncode == 1:
# return code 1 seems ok here
packages = oserr.stdout
elif oserr.returncode != 127:
print(f'failed. returncode={oserr.returncode}. stdout:\n{oserr.stdout}\nstderr:\n{oserr.stderr}')
raise
else:
# retry - maybe we have an centos based image
packages = _run_in_image(image_uri, ('yum', 'list', '--quiet', 'installed'))
print(f'Packages for {image_uri}:\n{packages}')
return _get_digest(packages.encode())

Expand All @@ -207,15 +226,17 @@ def _run_in_image(image_uri: str, command: Tuple[str, ...]) -> str:
'--rm',
'--net=none',
'--user=nobody',
'--name', 'tmp_' + str(random.randint(10000, 50000)),
'--entrypoint', command[0],
image_uri,
*command,
*command[1:],
)
return _check_output_and_print(run_command)


def _check_output_and_print(command: Tuple[str, ...]) -> str:
print(' '.join(command))
output = subprocess.check_output(command, encoding='utf-8')
output = subprocess.check_output(command, encoding='utf-8', stderr=subprocess.STDOUT)
return output


Expand Down