Update generator to consider 201 as success response code #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdakran
approved these changes
Aug 31, 2023
nasimmaleki
approved these changes
Aug 31, 2023
nasimmaleki
reviewed
Aug 31, 2023
| @@ -140,6 +140,8 @@ def _generate_request_graph() -> Dict[str, set]: | |||
| for operation_id in dir(getattr(client, tag_group)): | |||
| operation = getattr(getattr(client, tag_group), operation_id).operation | |||
| responses = operation.op_spec.get('responses', {}).get('200', {}) | |||
| if not responses: | |||
There was a problem hiding this comment.
Im just suggesting this cause 200 and 201 are not happening the same time!
Suggested change
| if not responses: | |
| responses = operation.op_spec.get('responses', {}) | |
| responses = responses.get('200', {}) or responses.get('201', {}) |
There was a problem hiding this comment.
Looks good. I'll include it with future changes 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The generated graph from swagger docs only considers 200 as success response code.
For the purpose of fuzz-lightyear,
201is another useful response code mainly used forcreateapis.How has this been tested
vulnerable_app