Remove spark SignalFx dashboard URLs (#143)

Yelp · Mar 12, 2024 · a1240e5 · a1240e5
1 parent e427503
commit a1240e5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 29 deletions.
diff --git a/service_configuration_lib/spark_config.py b/service_configuration_lib/spark_config.py
@@ -1209,18 +1209,6 @@ def get_grafana_url(spark_conf: Mapping[str, str]) -> str:
     )
 
 
-def get_signalfx_url(spark_conf: Mapping[str, str]) -> str:
-    return (
-        'https://app.signalfx.com/#/dashboard/FOjL2yRAcAA?density=4'
-        '&variables%5B%5D=Instance%3Dinstance_name:'
-        '&variables%5B%5D=Service%3Dservice_name:%5B%22spark%22%5D'
-        f"&variables%5B%5D=PaaSTA%20Cluster%3Dpaasta_cluster:{spark_conf['spark.executorEnv.PAASTA_CLUSTER']}"
-        f"&variables%5B%5D=PaaSTA%20Service%3Dpaasta_service:{spark_conf['spark.executorEnv.PAASTA_SERVICE']}"
-        f"&variables%5B%5D=PaaSTA%20Instance%3Dpaasta_instance:{spark_conf['spark.executorEnv.PAASTA_INSTANCE']}"
-        '&startTime=-1h&endTime=Now'
-    )
-
-
 def get_resources_requested(spark_opts: Mapping[str, str]) -> Mapping[str, int]:
     num_executors = (
         # spark on k8s directly configure num instances

diff --git a/tests/spark_config_test.py b/tests/spark_config_test.py
@@ -1537,23 +1537,6 @@ def test_get_grafana_url():
     )
 
 
-def test_get_signalfx_url():
-    spark_conf = {
-        'spark.executorEnv.PAASTA_CLUSTER': 'test-cluster',
-        'spark.executorEnv.PAASTA_SERVICE': 'test-service',
-        'spark.executorEnv.PAASTA_INSTANCE': 'test-instance',
-    }
-    assert spark_config.get_signalfx_url(spark_conf) == (
-        'https://app.signalfx.com/#/dashboard/FOjL2yRAcAA?density=4'
-        '&variables%5B%5D=Instance%3Dinstance_name:'
-        '&variables%5B%5D=Service%3Dservice_name:%5B%22spark%22%5D'
-        '&variables%5B%5D=PaaSTA%20Cluster%3Dpaasta_cluster:test-cluster'
-        '&variables%5B%5D=PaaSTA%20Service%3Dpaasta_service:test-service'
-        '&variables%5B%5D=PaaSTA%20Instance%3Dpaasta_instance:test-instance'
-        '&startTime=-1h&endTime=Now'
-    )
-
-
 @pytest.mark.parametrize(
     'spark_opts,expected_output', [
         # mesos ( 2 instances, not configure memory overhead, default: 384m )