Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ilo_api_mem.py #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

systeembeheerder
Copy link

Plugin fails to detect warning state in module; fixed syntax.

Python 3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> health="Warning"
>>> if health == "Good" or "OK":
...   print ("strange")
...
strange
>>>

Plugin fails to detect warning state in module; fixed syntax. 

    Python 3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0] on linux
    Type "help", "copyright", "credits" or "license" for more information.
    >>> health="Warning"
    >>> if health == "Good" or "OK":
    ...   print ("strange")
    ...
    strange
    >>>
@systeembeheerder
Copy link
Author

@Yogibaer75 in your code

if data[3] == "GoodInUse" or "OK":

gives the wrong results. See the test above.

@Yogibaer75
Copy link
Owner

Can you please migrate the checks to the generic redfish agent?
I joined all the manufacturer versions to one special agent.
This one is then the only one who gets fixed and further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants