Merge pull request #746 from sedenkovvlad/bug/duplication-video

Fixed a bug with video duplication when cropping
Yummypets · May 25, 2022 · f335418 · f335418
2 parents 3d37d04 + bfa9045
commit f335418
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/Source/Filters/Video/YPVideoFiltersVC.swift b/Source/Filters/Video/YPVideoFiltersVC.swift
@@ -93,7 +93,7 @@ public final class YPVideoFiltersVC: UIViewController, IsMediaFilterVC {
             .addObserver(self,
                          selector: #selector(itemDidFinishPlaying(_:)),
                          name: .AVPlayerItemDidPlayToEndTime,
-                         object: nil)
+                         object: videoView.player.currentItem)
 
         // Set initial video cover
         imageGenerator = AVAssetImageGenerator(asset: self.inputAsset)

diff --git a/Source/Filters/Video/YPVideoView.swift b/Source/Filters/Video/YPVideoView.swift
@@ -44,9 +44,6 @@ public class YPVideoView: UIView {
         singleTapGR.numberOfTapsRequired = 1
         addGestureRecognizer(singleTapGR)
 
-        // Loop playback
-        addReachEndObserver()
-
         playerView.alpha = 0
         playImageView.alpha = 0.8
         playerLayer.videoGravity = .resizeAspect
@@ -153,13 +150,13 @@ extension YPVideoView {
         NotificationCenter.default.addObserver(self,
                                                selector: #selector(playerItemDidReachEnd(_:)),
                                                name: .AVPlayerItemDidPlayToEndTime,
-                                               object: nil)
+                                               object: player.currentItem)
     }
 
     /// Removes the observer for AVPlayerItemDidPlayToEndTime. Could be needed to implement own observer
     public func removeReachEndObserver() {
         NotificationCenter.default.removeObserver(self,
                                                   name: .AVPlayerItemDidPlayToEndTime,
-                                                  object: nil)
+                                                  object: player.currentItem)
     }
 }