🔒 Fix username length check on login packets

YvanMazy · Apr 9, 2024 · aa85ab5 · aa85ab5
1 parent 0fe628e
commit aa85ab5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../java/be/darkkraft/transferproxy/network/packet/login/clientbound/LoginSuccessPacket.java b/.../java/be/darkkraft/transferproxy/network/packet/login/clientbound/LoginSuccessPacket.java
@@ -39,7 +39,7 @@ public record LoginSuccessPacket(UUID uuid, String username, Property[] properti
 
     public LoginSuccessPacket(final @NotNull ByteBuf buf) {
         this(readUUID(buf),
-                readString(buf),
+                readString(buf, 16),
                 readArray(buf,
                         Property[]::new,
                         sub -> new Property(readString(sub), readString(sub), sub.readBoolean() ? readString(buf) : null),
@@ -49,7 +49,7 @@ public LoginSuccessPacket(final @NotNull ByteBuf buf) {
     @Override
     public void write(final @NotNull ByteBuf buf) {
         writeUUID(buf, this.uuid);
-        writeString(buf, this.username);
+        writeString(buf, this.username, 16);
         if (this.properties == null) {
             writeVarInt(buf, 0);
             return;

diff --git a/...in/java/be/darkkraft/transferproxy/network/packet/login/serverbound/LoginStartPacket.java b/...in/java/be/darkkraft/transferproxy/network/packet/login/serverbound/LoginStartPacket.java
@@ -39,7 +39,7 @@
 public record LoginStartPacket(String name, UUID uuid) implements ServerboundPacket {
 
     public LoginStartPacket(final @NotNull ByteBuf buf) {
-        this(readString(buf), readUUID(buf));
+        this(readString(buf, 16), readUUID(buf));
     }
 
     @Override
@@ -54,7 +54,7 @@ public void handle(final @NotNull PlayerConnection connection) {
 
     @Override
     public void write(final @NotNull ByteBuf buf) {
-        writeString(buf, this.name);
+        writeString(buf, this.name, 16);
         writeUUID(buf, this.uuid);
     }