Add Support for SpiderHeck #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, and I'm glad that the tool was helpful! I tried to resolve the README conflict using GitHub UI, but it created an ugly merge commit and now the UI doesn't let me rebase-merge this 😅 Can you please rebase your forked branch and throw away my merge commit (or just create a new branch and a new pull request if that's easier for you)? Thanks! |
|
@Z1ni Should be good to merge now 😄 if you wanted to squash my commit when you merge, it should get rid of the unsightly commits but still retain attribution and history via the PR link in the squash merge title. For example, a squashed commit would read something like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, @Z1ni! I added this for myself in my own fork (and verified it works), so I thought I'd create a PR to get it upstream in case it helps anyone in the future. Feel free to do with the PR as you please. :)
Also... Thanks so much for creating this tool. It was beyond helpful.