New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #2866

Merged

madame-rachelle merged 4 commits into ZDoom:master from RicardoLuis0:misc-fixes

Dec 21, 2024

Collaborator

RicardoLuis0 commented Dec 21, 2024

add snd_footstepvolume to sound options menu
fix TranslationID casting
add helper methods to Sound/SpriteID/TranslationID
allow nullptr with SpriteID/TextureID/TranslationID (closes [Feature] Option to define a null TextureID #2663)

RicardoLuis0 added 4 commits

December 20, 2024 22:34


          add snd_footstepvolume to sound options menu

4ca9358

(SNDMNU_FOOTSTEPVOLUME is already in the spreadsheet, but only for en/pt so far)


          fix TranslationID casting


          add helper methods to Sound/SpriteID/TranslationID

7f6fe07


          allow nullptr with spriteid/textureid/translationid (for default para…

d9f9e18

…meters/etc)

Contributor

TehRealSalt commented Dec 21, 2024

Thank you so much! TranslationID is practically unusable without 7163596 and 7f6fe07

madame-rachelle merged commit bdddfcc into ZDoom:master

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet